tenacityteam / tenacity-legacy

THIS REPO IS NOT MAINTAINED ANYMORE. Please see https://codeberg.org/tenacityteam/tenacity for Tenacity, which is maintained.
https://tenacityaudio.org
Other
6.8k stars 262 forks source link

cmake/vcpkg: libwinpthread failed to downlaod #727

Closed voltagex closed 2 years ago

voltagex commented 2 years ago

Guidelines

Version/Commit hash

9b4b96d989615aeddaf141b93f82afb8c1eecf7b

Describe the bug.

Attempt to load the project in VS2022. Initialisation fails. vcpkg-bootstrap.log vcpkg-manifest-install.log

https://repo.msys2.org/mingw/i686/mingw-w64-i686-libwinpthread-git-8.0.0.5906.c9a21571-1-any.pkg.tar.zst: failed: status code 404

The latest/only version of that in the msys2 repo is https://repo.msys2.org/mingw/i686/mingw-w64-i686-libwinpthread-git-8.0.0.6001.98dad1fe-3-any.pkg.tar.zst

Expected behavior

Prerequisites download successfully, able to begin the build

OS

Windows 10

Additional context

No response

This issue is not a duplicate

voltagex commented 2 years ago

Searching shows there's a hardcoded version in a couple of files for some reason:

vcpkg/scripts/cmake/vcpkg_acquire_msys.cmake
534:        URL "https://repo.msys2.org/mingw/x86_64/mingw-w64-x86_64-libwinpthread-git-8.0.0.5906.c9a21571-1-any.pkg.tar.zst"

vcpkg/scripts/cmake/vcpkg_find_fortran.cmake
54:                        "https://repo.msys2.org/mingw/i686/mingw-w64-i686-libwinpthread-git-8.0.0.5906.c9a21571-1-any.pkg.tar.zst"
92:                        "https://repo.msys2.org/mingw/x86_64/mingw-w64-x86_64-libwinpthread-git-8.0.0.5906.c9a21571-1-any.pkg.tar.zst"
voltagex commented 2 years ago

Ah, sorry - this probably should be opened on your fork of vcpkg, can this be moved easily?

Be-ing commented 2 years ago

I'll update the vcpkg submodule.

Be-ing commented 2 years ago

728

Be-ing commented 2 years ago

Wtf GitHub, pressing Tab then Enter from a comment box should not close the issue. Why is this still a problem??

Be-ing commented 2 years ago

728 has been merged. Now this can be closed.