search

tenacityteam / tenacity-legacy

THIS REPO IS NOT MAINTAINED ANYMORE. Please see https://codeberg.org/tenacityteam/tenacity for Tenacity, which is maintained.
https://tenacityaudio.org
Other
6.75k stars 255 forks source link

Integrate native dark theme #83

Open peepo5 opened 3 years ago

peepo5 commented 3 years ago

Is your feature request related to a problem? Please describe. I am frustrated when all other apps have dark theme except this. It is easier on the eyes and should be a standard option.

Describe the solution you'd like Please integrate a native dark theme / theme manager that can switch between light and dark.

Describe alternatives you've considered Borrowing some code from darkaudacity

EricBright commented 3 years ago

Could be correlated with #29.

peepo5 commented 3 years ago

This is a slightly different issue but not a duplicate. This could be looked differently to #29; dark theme does not have to be default.

29 infers that default theme would be different (and not necessarily dark)

rollerozxa commented 3 years ago

Uhh, doesn't Audacity already have a dark theme built-in? It's not default, but you can pick it in the preferences.

rubycasey commented 3 years ago

There should be a dark theme already under Edit > Preferences > Interface

peepo5 commented 3 years ago

image It is not full dark theme, its mixed. There are lots of white elements here. I am talking about full dark theme, not half-dark. Also this theme is more grey-ish than dark.

abb128 commented 3 years ago

image On Linux with a dark system GTK theme, the existing dark theme is already perfect.

falkTX commented 3 years ago

Using wxWidgets which draws from native widgets on windows and macOS makes this difficult. On the long-term future, switching to qt backend of wxwidgets might be an option, audacity devs seemed interested in the idea. See discussion number 877 at https://github.com/audacity/audacity/discussions/ for context.

I am reposting the screenshots I have on that discussion. Note that for now this is not usable, but could be a long-term effort.

image image image image

peepo5 commented 3 years ago

I think that your theme locking the theme is a bad feature. I am not exactly sure how interfaces like these work, but I think the differing elements should be decided by audacity rather than OS.

Songtech-0912 commented 3 years ago

@peepopoggers See https://github.com/tenacityteam/tenacity/discussions/159#discussioncomment-982430, perhaps that is what you intended?

nyanpasu64 commented 3 years ago

In GTK3, applications can request a dark or light GTK theme. Audacity Tenacity could request a dark GTK theme when the Interface -> Theme is set to Dark (or perhaps request a light GTK theme when set to Light). I'm not sure how to do it through WxWidgets though.