tencent-ailab / hifi3dface

Code and data for our paper "High-Fidelity 3D Digital Human Creation from RGB-D Selfies".
Other
756 stars 153 forks source link

【BUG】bfs find bug in SparseFusion.py #25

Closed LiuLinyun closed 3 years ago

LiuLinyun commented 3 years ago

In file "optimization/rgbd/RGBD_utils/SparseFusion.py" line 57 :

queue = [[x + 1, y], [x - 1, y], [x, y - 1], [x, y - 1]]

the last element [x, y-1] should be [x, y+1] ?

because it is a bfs algorithm and coordinate [x, y+1] will be visited in next loop immediately, maybe this bug will not have much bad effect on result.

lxk121lalala commented 3 years ago

Thank you. We'll fix it right away

haoxianzGit commented 3 years ago

We have fixed this bug. Thank you.