tencent-quantum-lab / tensorcircuit

Tensor network based quantum software framework for the NISQ era
https://tensorcircuit.readthedocs.io
Apache License 2.0
252 stars 75 forks source link

Dev #186

Closed FelixXu35 closed 9 months ago

FelixXu35 commented 10 months ago

I partially rewrote the portfolio optimisation tutorial into two new ones.

Mixers and cvar are discussed in these two tutorials, respectively.

They passed the grammar, format and sphinx check.

If the new tutorials work, I am going to delete the old one.

review-notebook-app[bot] commented 10 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

refraction-ray commented 10 months ago

also please modify this file accordingly is the same PR: https://github.com/tencent-quantum-lab/tensorcircuit/blob/master/docs/source/tutorial.rst

codecov[bot] commented 10 months ago

Codecov Report

Merging #186 (31d47ad) into master (b96a1b1) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #186   +/-   ##
=======================================
  Coverage   75.50%   75.50%           
=======================================
  Files          67       67           
  Lines       10668    10668           
=======================================
  Hits         8055     8055           
  Misses       2613     2613           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

refraction-ray commented 10 months ago

please use all lower letters for the file name, qubo instead of QUBO

FelixXu35 commented 9 months ago

I refactored cvar_value, cvar_from_circuit, and cvar_from_expectation. Now jit=True saves 1/3 time.

refraction-ray commented 9 months ago

Now jit=True saves 1/3 time

This is subtle, I expect orders of magnitude acceleration with jit. The implementation looks correct to me.