tencherry10 / shellinabox

Automatically exported from code.google.com/p/shellinabox
Other
0 stars 0 forks source link

vt100.js not working in IE9 #118

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
If used with the just released IE9, vt100.js does not work correctly.

I tracked it down to newCursor.clientHeight not immediately computed inside 
VT100.prototype.resizer.

While I don't know, why it is not computed and my fix will probably break other 
things, I got it working for me for now using the modification below. Note, 
that I only added "false && " in the line with the FIXME comment.

Steffen

---

VT100.prototype.resizer = function() {
  // The cursor can get corrupted if the print-preview is displayed in Firefox.
  // Recreating it, will repair it.
  var newCursor                = document.createElement('pre');
  this.setTextContent(newCursor, ' ');
  newCursor.id                 = 'cursor';
  newCursor.style.cssText      = this.cursor.style.cssText;
  this.cursor.parentNode.insertBefore(newCursor, this.cursor);
  if (false && !newCursor.clientHeight) { // FIXME This was done to support IE9.
    // Things are broken right now. This is probably because we are
    // displaying the print-preview. Just don't change any of our settings
    // until the print dialog is closed again.
  ...

Original issue reported on code.google.com by steffen....@gmail.com on 21 Mar 2011 at 9:43

GoogleCodeExporter commented 8 years ago
I cannot get shellinabox working at all in IE9.  It keeps on writing to a 
single line at the top and is completely unusable.

This is not a big problem usually, but would be if I wanted to access my server 
when I only have IE available.

Does anybody know what could be happening?  I am running through HTTPS, if that 
makes a difference.

Original comment by gomez...@gmail.com on 16 Aug 2011 at 8:46

GoogleCodeExporter commented 8 years ago
You need to use IE9 compatibility mode. It is under developer tools, push F12 
and it is there.

Original comment by bluber...@gmail.com on 7 Nov 2011 at 11:24

GoogleCodeExporter commented 8 years ago
If you have just a single line, appy the fix I described above.
Also, newer updates of IE9 seem to make scripts containing /*@*/ fail. I 
replaced them with /* at */ and it works again. Stange.

Sadly, this project seems not to be supported any more.

Original comment by steffen....@gmail.com on 23 Nov 2011 at 3:16

GoogleCodeExporter commented 8 years ago
Note, /*@*/ occurs twice in vt100.js

Original comment by steffen....@gmail.com on 23 Nov 2011 at 3:18

GoogleCodeExporter commented 8 years ago
For what it's worth, this patch worked well for me.  Thanks!

Original comment by ecrist-...@claimlynx.com on 1 Jun 2012 at 7:13