search

tenderlove / ds9

Wrapper around nghttp2
80 stars 13 forks source link

Build nghttp2 #11

Closed ganmacs closed 5 years ago

ganmacs commented 5 years ago

deps https://github.com/tenderlove/ds9/pull/10

I think it's too tough to build nghttp2 by myself when I use ds9 in a container or a production server. So I added a code that builds nghttp2 while installing ds9.

FYI. I checked that code works good in my local environment ( macOS Mojave 10.14 ) and Travis CI https://github.com/ganmacs/grpc_kit/pull/9, https://travis-ci.org/ganmacs/grpc_kit/builds/462147468).

@tenderlove What do you think?

tenderlove commented 5 years ago

I think I'm okay with it, but doesn't nghttp2 require boost? I usually use nghttp2 from a package, not from source because of dependencies.

ganmacs commented 5 years ago

doesn't nghttp2 require boost?

No, it doesn't. libnghttp2_asio requires boost library, but nghttp2 (with --enable-lib-only option) doesn't.

ref: https://nghttp2.org/documentation/package_README.html#requirements

ganmacs commented 5 years ago

Are there any comments or questions? If you are not, I'll merge this.

tenderlove commented 5 years ago

Ah cool. Ya, I think it's fine! :)

ganmacs commented 5 years ago

Thanks for reviewing. I released this as v1.3.1.