Not to build dynamic library

tenderlove / ds9

Wrapper around nghttp2

80 stars 13 forks source link

Not to build dynamic library #12

Closed ganmacs closed 5 years ago

ganmacs commented 5 years ago

follow up https://github.com/tenderlove/ds9/pull/11

We don't need to build a dynamic library of nghttp2 but to build nghttp2 with -fPIC option. so, I added --with-pic option, and remove --enable-lib-only option.

l15n commented 4 years ago

@ganmacs Why did you choose to remove --enable-lib-only? I understand that it's basically shorthand for --disable-app --disable-examples --disable-hpack-tools --disable-python-bindings for those who only want libnghttp2. As far as I can tell, this is all that ds9 really needs.

I've found that its really common for gem users to have trouble installing the gem in their environments when they have python available, especially via pyenv.