Closed orien closed 1 year ago
@orien Do you have any idea why the CI is passing although we're still requiring rails
in test/test_rails_autolink.rb#L4?
@amatsuda Thanks for the thorough review 🙇
The require 'rails'
statement is actually satisfied by the railties
gem.
See: https://github.com/rails/rails/blob/7-0-stable/railties/lib/rails.rb
Indeed! Thank you for clarifying!
rails_autolink
declares a runtime dependency onrails
. This brings in transitive dependencies likeactioncable
,activerecord
, andactivestorage
. These aren't strictly necessary to userails_autolink
.I propose to reduce the declared runtime dependencies by replacing
rails
withactionview
,activesupport
, andrailties
. This will give downstream projects the ability to be more selective in the Rails dependencies they use.