search

tendermint / coding

14 stars 10 forks source link

no anonymous imports! #34

Closed zramsay closed 6 years ago

zramsay commented 6 years ago

yes:

import (
    "github.com/dot/package/unique"
)

var ordinary *unique.Whatever

no:

import (
    . "github.com/dot/package/unique"
)

var ordinary *Whatever
adrianbrink commented 6 years ago

I think it depends on the situation. It should generally be avoided but there are places in our code where it makes sense.