Closed dongsam closed 2 years ago
Great work! LGTM other than the following question.
In
keeper/genesis.go
, i seeGetAllBalances
is used in bothInitGenesis
andExportGenesis
. Am I understanding correctly that the function must be used to include all the account balances?
@kogisin That's right, unlike using SpendableCoins elsewhere accompanied by Send, Genesis uses GetAllBalances because it is for verification, not send, and the vesting locked amount of export and init varies depending on the block time, which can break the invariant of SpendableCoins.
Description
closes: #251
Tasks
Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes