tendermint / flutter

23 stars 10 forks source link

refactor: Add config for generating assets using `build_runner` and `flutter_gen` #260

Closed wal33d006 closed 2 years ago

Zfinix commented 2 years ago

Is there any reason we are adding build_runner and flutter_gen at the same time, I actually feel like we shouldn't do this as it forces flutter to add all the assets at runtime, while including the complexity of running build_runner each time in the background or any time we add a new asset, Sadly i fail to see the advantages

wal33d006 commented 2 years ago

According to the documentation of flutter_gen, we need to do that, and since we are shifting to generated assets instead if quoted strings, this would be required. This was actually something that was intended for the product, I thought I should add it in the shared code as well for consistency. We can leave it like this for shared code if we want. cc: @andrzejchm

Is there any reason we are adding build_runner and flutter_gen at the same time, I actually feel like we shouldn't do this as it forces flutter to add all the assets at runtime, while including the complexity of running build_runner each time in the background or any time we add a new asset, Sadly i fail to see the advantages

wal33d006 commented 2 years ago

I think we should abandon this PR