tendermint / go-amino

Protobuf3 with Interface support - Designed for blockchains (deterministic, upgradeable, fast, and compact)
Other
260 stars 78 forks source link

Default encoding of unsigned ints #237

Closed liamsi closed 5 years ago

liamsi commented 5 years ago

Summary of proposed changes: https://github.com/tendermint/tendermint/issues/2684

tl;dr: Current encoding in amino: amino's int32 matches protobuf's zigzag32 (which is an sint32 in the proto file and which generates a int32 but zigzag32 encoded in go-lang) Desired behaviour: default e.g., int32 encoding to protobuf's varint encoding (which is a int32 in the proto file and which also generates a int32 in go-lang but varint encoded)

liamsi commented 5 years ago

closed via #238