tendermint / go-amino

Protobuf3 with Interface support - Designed for blockchains (deterministic, upgradeable, fast, and compact)
Other
260 stars 78 forks source link

Error message not concise #251

Open patrickwieth opened 5 years ago

patrickwieth commented 5 years ago

So this is not a real bug, but an error message that could be more helpful:

https://github.com/tendermint/go-amino/blob/master/amino.go#L337

The error message fits well for the case in L339 but in L337 it should not inform that the prefix bytes are wrong but are missing. I thought I messed up registering the codec or something like this but actually the data was empty due to another bug.

liamsi commented 5 years ago

Thanks @patrickwieth!