tendermint / go-amino

Protobuf3 with Interface support - Designed for blockchains (deterministic, upgradeable, fast, and compact)
Other
260 stars 78 forks source link

Add Go modules support but keep dep support #255

Closed liamsi closed 5 years ago

liamsi commented 5 years ago

cc @jackzampolin

liamsi commented 5 years ago

Interestingly, some combination of updated dependencies reveals a failing test: https://circleci.com/gh/tendermint/go-amino/521?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link (can be reproduced locally, there is an error where a panic is expected -> testify let this pass unnoticed ...)

liamsi commented 5 years ago

Meh, I've opened https://github.com/tendermint/go-amino/issues/256 It's probably worth to fix the tests here directly.

liamsi commented 5 years ago

Thanks @melekes!