Improve Ledger error handling, change PrivKey API

tendermint / go-crypto

DEPRECATED: Merged into https://github.com/tendermint/tendermint under `crypto`

Other

44 stars 32 forks source link

Improve Ledger error handling, change PrivKey API #114

Closed cwgoes closed 6 years ago

cwgoes commented 6 years ago

At the moment, most of the PrivKey methods (Sign, PubKey) don't have a way to return errors, so we must panic if we can't query the Ledger. This will also be a problem with future HW wallets or any other kind of asynchronous signatures.

Changing these interfaces might be annoying downstream though.

cwgoes commented 6 years ago

Implemented in https://github.com/tendermint/go-crypto/pull/117.

liamsi commented 6 years ago

resolved in #117 added the changes we discussed a separate issue #129