Closed cwgoes closed 6 years ago
To-do:
.Sign()
based on keytype@Liamsi Thoughts on the API changes?
The interface changes look good to me! Totally in favour of sign returning an error. I also like changing Info to an interface. I might change the Create
to CreateMneomnicKey
or simply CreateMnemonic
(as the key is clear because of the context/package name/iface name) in https://github.com/tendermint/go-crypto/pull/118
Rework
PrivKey
,Keybase
, andInfo
to work with both locally stored and external keys (offline, HW wallets, etc).This involves the following API changes:
privkey.Sign()
andprivkey.PubKey()
, as we may be querying an external datastoreKeybase
interface to track Ledger HD ed25519 keys and offline keys, so that signing by name automatically looks up the right key and prompts the user for a password / communicates with the Ledger / prompts the user to sign offline, as appropriate.