tendermint / go-crypto

DEPRECATED: Merged into https://github.com/tendermint/tendermint under `crypto`
Other
44 stars 32 forks source link

Unify local and external keys in keybase interface #117

Closed cwgoes closed 6 years ago

cwgoes commented 6 years ago

Rework PrivKey, Keybase, and Info to work with both locally stored and external keys (offline, HW wallets, etc).

This involves the following API changes:

cwgoes commented 6 years ago

To-do:

cwgoes commented 6 years ago

@Liamsi Thoughts on the API changes?

liamsi commented 6 years ago

The interface changes look good to me! Totally in favour of sign returning an error. I also like changing Info to an interface. I might change the Create to CreateMneomnicKey or simply CreateMnemonic (as the key is clear because of the context/package name/iface name) in https://github.com/tendermint/go-crypto/pull/118