search

tendermint / go-crypto

DEPRECATED: Merged into https://github.com/tendermint/tendermint under `crypto`
Other
44 stars 32 forks source link

Delete SimpleProofsFromMap #122

Closed liamsi closed 6 years ago

liamsi commented 6 years ago

Following up on a discussion with @mossid about returning the keys in an array additionally to the map (in https://github.com/tendermint/go-crypto/pull/115 :

Couldn't we pass a list of key-value pairs KVPairs as an argument instead of a map in: https://github.com/tendermint/go-crypto/blob/710efe576acfcc22ead7781cec67a1265cbba0b0/merkle/simple_proof.go#L30

Then we wouldn't need to sort the map.

Couldn't we then use SimpleProofsFromHashers instead then? @mossid

After discussing with @mossid: Yes, we can delete this. I'll do it before the next release (of go-crypto). (I'm happy to work on the changes in the SDK to take this off your plate @mossid)

liamsi commented 6 years ago

Was rediscussed offline with @mossid: could be kept as mere wrapper around SimpleProofsFromHashers instead. Moved to https://github.com/tendermint/tendermint/issues/1889