search

tendermint / go-crypto

DEPRECATED: Merged into https://github.com/tendermint/tendermint under `crypto`
Other
44 stars 32 forks source link

Package _nano is never build, never used, and doesn't compile #99

Closed liamsi closed 6 years ago

liamsi commented 6 years ago

copied over from https://github.com/tendermint/go-crypto/pull/96/files/ecc7cdfdf62350991fbfc092f2e51e4b1ee68091?utf8=%E2%9C%93&diff=unified#r188092482

the package _nano starts with an underscore. go build (and with it go test) completely ignores this package ... (see https://golang.org/pkg/go/build/#Context.Import)

The package doesn't build (remove the underscore to reproduce). This is most probably due to: https://github.com/golang/go/issues/23672 and a dependency: 

go build github.com/ethanfrey/hid: invalid flag in #cgo LDFLAGS: -fconstant-cfstrings
FAIL    github.com/tendermint/go-crypto/nano [build failed]

related: https://github.com/ethanfrey/ledger/issues/1#issuecomment-368486919

cwgoes commented 6 years ago

Superseded by https://github.com/tendermint/go-crypto/pull/85 I think.

liamsi commented 6 years ago

Thanks! #85 would also resolve #93 and make #96 obsolete then /cc @jessysaurusrex @ebuchman

cwgoes commented 6 years ago

Yes, all the low-level Ledger communication code now lives in https://github.com/zondax/ledger-goclient.

liamsi commented 6 years ago

Makes much more sense to me, too.

ebuchman commented 6 years ago

Thanks guys