search

tendermint / js-abci

Javascript ABCI libraries
87 stars 41 forks source link

Rename the name value #25

Closed craigpastro closed 5 years ago

craigpastro commented 5 years ago

As it currently is if I run npm install abci then I get an error: npm ERR! Refusing to install abci as a dependency of itself. This fixes it.

zramsay commented 5 years ago

thanks! somewhat fixes https://github.com/tendermint/tendermint/issues/2931

mappum commented 5 years ago

I just noticed this PR, FYI this should not have been merged.

@siyopao if you cloned the repo, you should have been installing with npm install, not npm install abci.

As for tendermint/tendermint#2931, that was an issue due to the example not having a package.json file (now fixed as of 45d1bd0314a24af60d6b2bf6814a306096036207).

This was reverted in 1cc7756b270dfaf1b5cec2b8ff135fd85fcb315a.