search

tendermint / js-abci

Javascript ABCI libraries
87 stars 41 forks source link

Upgrades protos to TM 0.26.1 #26

Closed davebryson closed 5 years ago

davebryson commented 5 years ago

This pull request updates types.js and index.d.ts to support Tendermint 0.26.1. The protos directory is out of date. I probably should have deleted the old proto files but I didn't want to step on too many toes.

I've tested this with Tendermint 0.26.1 against the tests and the counter.js app - all seem to work fine. There are 3 errors related to signatures in the test/fixtures.js, I assume these are do to protocol updates.

I have a separate quasi-automated build/update process for protos that I'll push to a separate repo shortly.

zramsay commented 5 years ago

thanks! standby for review

melekes commented 5 years ago

Awesome. Thanks!

zramsay commented 5 years ago

looks like this broke 3 tests

davebryson commented 5 years ago

looks like this broke 3 tests

I don't know about the 0.26.3 version (that wasn't mine), but I mentioned in my original pull request that there were 3 errors (I believe) related to 'signatures' in the fixtures. I assumed they may have changed due to Amino prefixes. Yes... I'll admit I was lazy and didn't check 😳

zramsay commented 5 years ago

ah, gotcha. i've reverted master to get the tests passing and now we have the CI up and running. it seems this PR broke 3 tests and #27 broke an additional one