search

tendermint / js-abci

Javascript ABCI libraries
87 stars 41 forks source link

Update ABCI types to Tendermint v0.26.3 #27

Closed marypreethi12 closed 5 years ago

zramsay commented 5 years ago

thanks! standby for review. Might need to rebase on #26

melekes commented 5 years ago

Can we get this rebased against latest master? Thank you

melekes commented 5 years ago

Awesome! Thanks

zramsay commented 5 years ago

https://github.com/tendermint/js-abci/commit/333f6a8ca80f940a43e76d63c300ee9740077742#diff-dfd7851767dfe20984bfb77eb69df4e9R8610

a couple lines left over from a rebase, caught by CI

zramsay commented 5 years ago

i think we'll have to revert this PR, looks like it broke the tests

zramsay commented 5 years ago

yup, reverted. could you re-open this PR now that there's a CI that will test the changes