bring back updates that broke tests

tendermint / js-abci

Javascript ABCI libraries

87 stars 41 forks source link

bring back updates that broke tests #32

Closed zramsay closed 5 years ago

zramsay commented 5 years ago

see #26 and #27 cc @davebryson and @marypreethi12

Sorry I had to revert those changes, discovered broken tests (npm test) while implementing the CI

davebryson commented 5 years ago

So essentially the fixture related tests are based on byte signatures from the older protocol. So updating the fixtures to the latest signatures should resolve the issue. Any recommendations on how to generate the signatures in the test/fixtures file?

marypreethi12 commented 5 years ago

i fixed some typo errors which were failing CI, however now we have 3 tests failed 11 passed, is it something to do with signature which @davebryson mentioned ?

mappum commented 5 years ago

Just had to update a test fixture, now this targets 0.26+. (#33 was merged)