search

tendermint / light-client

DEPRECATED: A light client for tendermint, supporting signatures, proofs, and validation (see github.com/tendermint/tendermint/lite)
Other
17 stars 9 forks source link

Rename proof to query #26

Closed ethanfrey closed 7 years ago

ethanfrey commented 7 years ago

Bucky wanted a simpler interface, more consistent with current Basecoin. I want security.

Let's just call it query and always do a proof.

Will be reworking the query cli in a few other issues as well, so let's throw this into the mix

rigelrozanski commented 7 years ago

I agree with the rename - It doesn't matter that the light client is doing proofs fundamentally the command is trying to query information, it just so happens that proofs are a part of being confident in the information which is being queried.

rigelrozanski commented 7 years ago

More on Bucky's comment here - I don't think that there is a problem with having lots of advanced CLI functionality within the light-client, I just think we need a better way for light-client plugins to pick and choose which type of functionality the user sees for their light-client-subset CLI. For example, as pointed out in https://github.com/tendermint/light-client/issues/27 plugins don't always need the proof state get to be exposed. Depending on the application, I think that it may also be irrelevant for a user to want to perform a proof tx. Again, this is still vital functionality to have in here, just not all plugins may want this option I reckon

ethanfrey commented 7 years ago

Fixed as part of #21