search

tendermint / light-client

DEPRECATED: A light client for tendermint, supporting signatures, proofs, and validation (see github.com/tendermint/tendermint/lite)
Other
17 stars 9 forks source link

Let's online the assertions #6

Closed ebuchman closed 7 years ago

ebuchman commented 7 years ago

func (o *OneSig) assertSignable() lightclient.Signable { return o }

Can we add this to a coding standard?

ethanfrey commented 7 years ago

You like? It's nice as long as it doesn't cause circular imports, which it could. Be great in early development to be sure.

I will add a line to coding. You can preach the gospel ;)

ethanfrey commented 7 years ago

@ebuchman Sorry for letting this lag. Is there an actionable item to do here or is it more a :+1: for the pattern?

ethanfrey commented 7 years ago

I think the more proper pattern is this:

var _ lc.Certifier = &StaticCertifier{}

I updated the code here.