tendermint / liquidity

Cosmos SDK Liquidity module
Apache License 2.0
135 stars 55 forks source link

fix: validation swap msg and offerCoinFee ceiling #436

Closed dongsam closed 3 years ago

dongsam commented 3 years ago

Description

closes: #435


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

codecov[bot] commented 3 years ago

Codecov Report

Merging #436 (f4022bd) into develop (33a5ca6) will increase coverage by 1.76%. The diff coverage is 50.00%.

:exclamation: Current head f4022bd differs from pull request most recent head 124c9d2. Consider uploading reports for the commit 124c9d2 to get more accurate results Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #436      +/-   ##
===========================================
+ Coverage    83.36%   85.13%   +1.76%     
===========================================
  Files           20       20              
  Lines         2302     2596     +294     
===========================================
+ Hits          1919     2210     +291     
- Misses         218      223       +5     
+ Partials       165      163       -2     
Impacted Files Coverage Δ
x/liquidity/types/utils.go 83.33% <37.50%> (-8.98%) :arrow_down:
x/liquidity/types/swap.go 79.10% <60.00%> (+0.78%) :arrow_up:
x/liquidity/keeper/liquidity_pool.go 84.03% <100.00%> (+2.22%) :arrow_up:
x/liquidity/abci.go 100.00% <0.00%> (ø)
x/liquidity/genesis.go 100.00% <0.00%> (ø)
x/liquidity/handler.go 100.00% <0.00%> (ø)
x/liquidity/types/keys.go 100.00% <0.00%> (ø)
x/liquidity/types/msgs.go 100.00% <0.00%> (ø)
x/liquidity/types/codec.go 100.00% <0.00%> (ø)
x/liquidity/types/genesis.go 100.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 33a5ca6...124c9d2. Read the comment docs.