proto: extend tooling support

cmwaters commented 3 years ago

Summary

https://github.com/tendermint/tendermint/pull/6976 canonicalized the source of the proto files to the spec repository. I think we need to better equip the spec repository to these changes. Specifically:

[ ] Check proto files "compile". I think currently there are some missing dependencies which mean the proto files in the spec can't properly generate anything. This should be a github action that runs whenever someone modifies the proto files in a PR.
[ ] Port over the docker-build-protoDockerfile to the spec as well as the github action that pushes monthly releases to dockerhub.
[ ] Check for proto breaking changes (optional). We have this github action in Tendermint that warns for breaking changes which we may want to port across merely to signal when proposed changes are breaking. I also don't mind removing this.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

williambanfield commented 3 years ago

Looking at the failing compile step, the missing dependency is the gogoproto/gogo.proto. This used to be contained in the tendermint repository in the third_party/ directory. We can either put it into our Dockerfile that contains the tendermint build tools or put it into the repo directly under the spec/ directory. I'm not sure it makes much difference which one we choose.

cmwaters commented 2 years ago

Proto's have been moved to tendermint/tendermint so I think it's okay to close this

tendermint / spec

proto: extend tooling support #354

Summary

For Admin Use