tendermint / spec

131 stars 56 forks source link

Revert "proto: abci++ changes (#348)" #360

Closed williambanfield closed 3 years ago

williambanfield commented 3 years ago

This reverts commit caaafc44498f06cda3af409ddca3338651b43e0d.

We don't currently have a version strategy that allows us to make this kind of breaking change. I'd like to reorder this commit to be after the updates to the build system so that I have a commit that builds stably against current tendermint.

Related, it appears that, when running the new proto tooling, a type is missing that is used in ABCI++. It references a VoteExtension type that is not defined: https://github.com/tendermint/spec/pull/360/files#diff-8384a26745c978d00d66edad2513d2c0518fab0ddb4123c613f475b88ed95667L302