Closed williambanfield closed 2 years ago
Allow these parameters to be pointers in the Go code doesn't actually buy us much: these parameters must be set and will be set on application startup, so allowing them to be nil only leaves a possible panic without much gain.
I'm fine forgoing them, I don't think it's that big of a risk and am certainly somewhat guilty of cargo-culting this into place.
Allow these parameters to be pointers in the Go code doesn't actually buy us much: these parameters must be set and will be set on application startup, so allowing them to be nil only leaves a possible panic without much gain.