tendermint / spec

131 stars 56 forks source link

make consensus parameters non nullable #402

Closed williambanfield closed 2 years ago

williambanfield commented 2 years ago

Allow these parameters to be pointers in the Go code doesn't actually buy us much: these parameters must be set and will be set on application startup, so allowing them to be nil only leaves a possible panic without much gain.

williambanfield commented 2 years ago

I'm fine forgoing them, I don't think it's that big of a risk and am certainly somewhat guilty of cargo-culting this into place.