tendermint / spn

A blockchain to launch blockchains.
Other
112 stars 43 forks source link

chore: upgrade IBC to v6 #1005

Closed aljo242 closed 1 year ago

aljo242 commented 1 year ago

Updates:

Modified monitoringp and monitoringc modules because the signature for SendPacket has been changed.

Tests working for me, but this could use some further investigation/testing

aljo242 commented 1 year ago

ignite/modules needs to be upgrade to ibc-go/v6 first. Then I can update the dependency.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1005 (222d312) into main (2316468) will increase coverage by 0.17%. The diff coverage is 72.72%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/tendermint/spn/pull/1005/graphs/tree.svg?width=650&height=150&src=pr&token=GMSSU7SM3A&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint)](https://codecov.io/gh/tendermint/spn/pull/1005?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint) ```diff @@ Coverage Diff @@ ## main #1005 +/- ## ========================================== + Coverage 71.27% 71.44% +0.17% ========================================== Files 215 215 Lines 9472 9446 -26 ========================================== - Hits 6751 6749 -2 + Misses 2549 2524 -25 - Partials 172 173 +1 ``` | [Impacted Files](https://codecov.io/gh/tendermint/spn/pull/1005?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint) | Coverage Δ | | |---|---|---| | [pkg/types/consensus\_state.go](https://codecov.io/gh/tendermint/spn/pull/1005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-cGtnL3R5cGVzL2NvbnNlbnN1c19zdGF0ZS5nbw==) | `100.00% <ø> (ø)` | | | [pkg/types/validator\_set.go](https://codecov.io/gh/tendermint/spn/pull/1005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-cGtnL3R5cGVzL3ZhbGlkYXRvcl9zZXQuZ28=) | `92.30% <ø> (ø)` | | | [x/monitoringc/keeper/handshake.go](https://codecov.io/gh/tendermint/spn/pull/1005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-eC9tb25pdG9yaW5nYy9rZWVwZXIvaGFuZHNoYWtlLmdv) | `100.00% <ø> (ø)` | | | [x/monitoringc/keeper/monitoring\_packet.go](https://codecov.io/gh/tendermint/spn/pull/1005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-eC9tb25pdG9yaW5nYy9rZWVwZXIvbW9uaXRvcmluZ19wYWNrZXQuZ28=) | `100.00% <ø> (ø)` | | | [x/monitoringc/keeper/msg\_create\_client.go](https://codecov.io/gh/tendermint/spn/pull/1005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-eC9tb25pdG9yaW5nYy9rZWVwZXIvbXNnX2NyZWF0ZV9jbGllbnQuZ28=) | `95.38% <ø> (ø)` | | | [x/monitoringc/module\_ibc.go](https://codecov.io/gh/tendermint/spn/pull/1005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-eC9tb25pdG9yaW5nYy9tb2R1bGVfaWJjLmdv) | `0.00% <ø> (ø)` | | | [x/monitoringc/types/genesis.go](https://codecov.io/gh/tendermint/spn/pull/1005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-eC9tb25pdG9yaW5nYy90eXBlcy9nZW5lc2lzLmdv) | `100.00% <ø> (ø)` | | | [x/monitoringp/keeper/consumer\_client.go](https://codecov.io/gh/tendermint/spn/pull/1005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-eC9tb25pdG9yaW5ncC9rZWVwZXIvY29uc3VtZXJfY2xpZW50Lmdv) | `71.42% <ø> (ø)` | | | [x/monitoringp/keeper/handshake.go](https://codecov.io/gh/tendermint/spn/pull/1005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-eC9tb25pdG9yaW5ncC9rZWVwZXIvaGFuZHNoYWtlLmdv) | `100.00% <ø> (ø)` | | | [x/monitoringp/module\_ibc.go](https://codecov.io/gh/tendermint/spn/pull/1005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-eC9tb25pdG9yaW5ncC9tb2R1bGVfaWJjLmdv) | `0.00% <ø> (ø)` | | | ... and [5 more](https://codecov.io/gh/tendermint/spn/pull/1005/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint) | |
lumtis commented 1 year ago

Modified monitoringp and monitoringc modules because the signature for SendPacket has been changed. Tests working for me, but this could use some further investigation/testing

There is just the sequence added as far as I can see and it is retrieve by the channel keeper. I don't see modification that influence verification logic

aljo242 commented 1 year ago

Ok - feel free to merge