search

tendermint / spn

A blockchain to launch blockchains.
Other
112 stars 43 forks source link

chore: update buf version and files #1017

Closed Pantani closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #1017 (a1947b4) into main (e5b0863) will decrease coverage by 0.02%. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/tendermint/spn/pull/1017/graphs/tree.svg?width=650&height=150&src=pr&token=GMSSU7SM3A&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint)](https://app.codecov.io/gh/tendermint/spn/pull/1017?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint) ```diff @@ Coverage Diff @@ ## main #1017 +/- ## ========================================== - Coverage 71.38% 71.37% -0.02% ========================================== Files 218 218 Lines 9471 9471 ========================================== - Hits 6761 6760 -1 - Misses 2538 2539 +1 Partials 172 172 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/tendermint/spn/pull/1017/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint)
jeronimoalbi commented 1 year ago

I'm not sure about this but it might be good to update/add the proto generation Makefile target as part of this PR to generate the code from the proto files using "Buf". Also we might consider changing the proto file layout to match the project layout. For example, proto/spn/launch/chain.proto might need to be x/launch/types/chain.proto.