Closed lumtis closed 2 years ago
Merging #871 (8c7a657) into develop (6bbb406) will decrease coverage by
0.02%
. The diff coverage is3.19%
.
@@ Coverage Diff @@
## develop #871 +/- ##
===========================================
- Coverage 10.42% 10.39% -0.03%
===========================================
Files 322 325 +3
Lines 75407 75688 +281
===========================================
+ Hits 7862 7869 +7
- Misses 67356 67630 +274
Partials 189 189
Impacted Files | Coverage Δ | |
---|---|---|
x/claim/keeper/mission_delegation_hooks.go | 0.00% <0.00%> (ø) |
|
x/claim/keeper/mission_vote_hooks.go | 0.00% <0.00%> (ø) |
|
x/claim/types/events.pb.go | 1.18% <1.18%> (ø) |
|
x/claim/keeper/mission.go | 96.20% <100.00%> (+0.25%) |
:arrow_up: |
x/campaign/simulation/store.go | 82.43% <0.00%> (-0.68%) |
:arrow_down: |
the simulation test is broken
Yep there was a bug! Not sure why it was only triggered in simulation and not on serve
Implement hooks for
staking
andgov
modules that allow to complete claim mission on the events:staking
gov
Set hooks in
app.go
as a sample implementation.Security mechanism remains to be designed: locking a specific mission ID for a specific module
Add event on mission completion
To test:
Serve:
Claim for delegation mission:
Claim for voting proposal:
Check balance for
drop
token:Check claim records: