search

tendermint / spn

A blockchain to launch blockchains.
Other
112 stars 43 forks source link

refactor(`claim`): add checks in genesis validate for already completed missions #877

Closed lumtis closed 2 years ago

lumtis commented 2 years ago

Already completed missions are now taken into account for checking the airdrop supply value

Add some other improvements

codecov[bot] commented 2 years ago

Codecov Report

Merging #877 (8a5ad75) into develop (b6a5d1d) will increase coverage by 0.02%. The diff coverage is 80.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #877      +/-   ##
===========================================
+ Coverage    10.43%   10.45%   +0.02%     
===========================================
  Files          326      326              
  Lines        76261    76273      +12     
===========================================
+ Hits          7957     7975      +18     
+ Misses       68113    68109       -4     
+ Partials       191      189       -2
Impacted Files Coverage Δ
x/claim/types/genesis.go 78.57% <78.78%> (+11.18%) :arrow_up:
x/claim/keeper/mission.go 96.20% <100.00%> (ø)
x/claim/types/claim_record.go 100.00% <100.00%> (ø)
x/campaign/simulation/store.go 83.10% <0.00%> (+2.02%) :arrow_up:
lumtis commented 2 years ago

Thanks for the approval @Pantani

I'm merging it now as https://github.com/tendermint/spn/issues/835 depends on it in some way