tendermint / spn

A blockchain to launch blockchains.
Other
112 stars 41 forks source link

refactor: remove `ignite` dep #911

Closed aljo242 closed 2 years ago

aljo242 commented 2 years ago

What does this PR does?

Removes the ignite dependency from the repository. Importing ignite introduces a set of circular dependencies because:

This cycle has made upgrading the packages very challenging, so this PR helps alleviate that. The main import was the pkg/cosmsocmd module which has now been added to the local cmd package. This functionality is commonly placed in this local package as can be seen with gaia. The openAPI code has also been removed. This can potentially be added back in later. We should prioritize decoupling from ignite-cli though.

Part of #909

These are the criteria that every PR should meet, please check them off as you review them:

codecov[bot] commented 2 years ago

Codecov Report

Merging #911 (ba13221) into develop (f310279) will increase coverage by 0.00%. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #911   +/-   ##
========================================
  Coverage    10.56%   10.56%           
========================================
  Files          327      327           
  Lines        75191    75191           
========================================
+ Hits          7942     7944    +2     
+ Misses       67060    67059    -1     
+ Partials       189      188    -1     
Impacted Files Coverage Δ
x/campaign/simulation/store.go 84.45% <0.00%> (+1.35%) :arrow_up: