search

tendermint / spn

A blockchain to launch blockchains.
Other
112 stars 43 forks source link

feat: buf proto generation #917

Closed aljo242 closed 2 years ago

aljo242 commented 2 years ago

What does this PR does?

Adds buf tooling and proto targets. This brings our codebase in line with the Cosmos-SDK and their proto compilation model.

I know we previously wanted to have no scripts in the repo, but this is the only way to get proto compilation working until ignite is updated. The work done in this PR can also serve as a guide for how to update ignite's proto compilation steps.

Either way, I think we should keep the buf tools as they can be pretty helpful.

Pulling this into our v0.46.0 branch because that makes the most sense.

Most of the modified files are just formatted .proto file and regenerated .pb.go files.

codecov[bot] commented 2 years ago

Codecov Report

Merging #917 (9cc3317) into feat/v0.46.0 (6bff668) will increase coverage by 0.00%. The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           feat/v0.46.0     #917   +/-   ##
=============================================
  Coverage         10.56%   10.56%           
=============================================
  Files               327      327           
  Lines             75202    75202           
=============================================
+ Hits               7942     7944    +2     
+ Misses            67071    67070    -1     
+ Partials            189      188    -1
Impacted Files Coverage Δ
x/campaign/types/query.pb.gw.go 0.00% <ø> (ø)
x/claim/types/query.pb.gw.go 0.00% <ø> (ø)
x/launch/types/query.pb.gw.go 0.00% <ø> (ø)
x/mint/types/query.pb.gw.go 0.00% <ø> (ø)
x/monitoringc/types/query.pb.gw.go 0.00% <ø> (ø)
x/monitoringp/types/query.pb.gw.go 0.00% <ø> (ø)
x/participation/types/params.pb.go 0.70% <ø> (ø)
x/participation/types/query.pb.gw.go 0.00% <ø> (ø)
x/profile/types/query.pb.gw.go 0.00% <ø> (ø)
x/reward/types/query.pb.gw.go 0.00% <ø> (ø)
... and 1 more
lumtis commented 2 years ago

Sounds good. I think we should support or adapt to buf with Ignite CLI

aljo242 commented 2 years ago

Sounds good. I think we should support or adapt to buf with Ignite CLI

Yeah, I think this is possible and will be important. Chains like:

use it. And the sdk and ibc-go use it as well.

Is it good to merge into the v0.46.0 branch?