tendermint / spn

A blockchain to launch blockchains.
Other
112 stars 43 forks source link

Simplifying `launch` module by merging all request related message to `MsgSendRequest` #928

Closed lumtis closed 2 years ago

lumtis commented 2 years ago

We used a specific message for each specific request because the implementation and related economics of the request logic was not yet determined. We now have lot of duplication of code because of having a message of each request. We should refactor this into a single message for simplicity and make it easier adding new requests in the future

Replacing

MsgRequestAddAccount
MsgRequestAddValidator
MsgRequestAddVestingAccount
MsgRequestRemoveAccount
MsgRequestRemoveValidator

into

MsgSendRequest

The message contains a request object