tendermint / spn

A blockchain to launch blockchains.
Other
112 stars 43 forks source link

feat(`launch`): change param request #957

Closed aljo242 closed 2 years ago

aljo242 commented 2 years ago

Closes #930

@lubtd let me know what you think !

codecov[bot] commented 2 years ago

Codecov Report

Merging #957 (533361b) into develop (6f6ae7d) will decrease coverage by 0.10%. The diff coverage is 4.92%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/tendermint/spn/pull/957/graphs/tree.svg?width=650&height=150&src=pr&token=GMSSU7SM3A&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint)](https://codecov.io/gh/tendermint/spn/pull/957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint) ```diff @@ Coverage Diff @@ ## develop #957 +/- ## =========================================== - Coverage 10.66% 10.55% -0.11% =========================================== Files 272 275 +3 Lines 65229 66486 +1257 =========================================== + Hits 6954 7017 +63 - Misses 58112 59300 +1188 - Partials 163 169 +6 ``` | [Impacted Files](https://codecov.io/gh/tendermint/spn/pull/957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint) | Coverage Δ | | |---|---|---| | [x/launch/keeper/grpc\_param\_change.go](https://codecov.io/gh/tendermint/spn/pull/957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-eC9sYXVuY2gva2VlcGVyL2dycGNfcGFyYW1fY2hhbmdlLmdv) | `0.00% <0.00%> (ø)` | | | [x/launch/keeper/request.go](https://codecov.io/gh/tendermint/spn/pull/957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-eC9sYXVuY2gva2VlcGVyL3JlcXVlc3QuZ28=) | `95.43% <0.00%> (-4.57%)` | :arrow_down: | | [x/launch/simulation/simulation.go](https://codecov.io/gh/tendermint/spn/pull/957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-eC9sYXVuY2gvc2ltdWxhdGlvbi9zaW11bGF0aW9uLmdv) | `0.00% <0.00%> (ø)` | | | [x/launch/simulation/store.go](https://codecov.io/gh/tendermint/spn/pull/957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-eC9sYXVuY2gvc2ltdWxhdGlvbi9zdG9yZS5nbw==) | `58.46% <0.00%> (-6.50%)` | :arrow_down: | | [x/launch/types/genesis.pb.go](https://codecov.io/gh/tendermint/spn/pull/957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-eC9sYXVuY2gvdHlwZXMvZ2VuZXNpcy5wYi5nbw==) | `1.02% <0.00%> (-0.08%)` | :arrow_down: | | [x/launch/types/params.go](https://codecov.io/gh/tendermint/spn/pull/957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-eC9sYXVuY2gvdHlwZXMvcGFyYW1zLmdv) | `76.31% <ø> (ø)` | | | [x/launch/types/query.pb.gw.go](https://codecov.io/gh/tendermint/spn/pull/957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-eC9sYXVuY2gvdHlwZXMvcXVlcnkucGIuZ3cuZ28=) | `0.00% <0.00%> (ø)` | | | [x/participation/simulation/simulation.go](https://codecov.io/gh/tendermint/spn/pull/957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-eC9wYXJ0aWNpcGF0aW9uL3NpbXVsYXRpb24vc2ltdWxhdGlvbi5nbw==) | `0.00% <ø> (ø)` | | | [x/launch/types/request.pb.go](https://codecov.io/gh/tendermint/spn/pull/957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-eC9sYXVuY2gvdHlwZXMvcmVxdWVzdC5wYi5nbw==) | `2.56% <0.30%> (-0.67%)` | :arrow_down: | | [x/launch/types/events.pb.go](https://codecov.io/gh/tendermint/spn/pull/957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-eC9sYXVuY2gvdHlwZXMvZXZlbnRzLnBiLmdv) | `0.48% <0.37%> (-0.02%)` | :arrow_down: | | ... and [6 more](https://codecov.io/gh/tendermint/spn/pull/957/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint) | |
aljo242 commented 2 years ago

Unit tests failing due to codecov upload