search

tendermint / tm-db

Common database interface for various database backends for Tendermint Core and Cosmos SDK
Apache License 2.0
89 stars 136 forks source link

Upgrades gorocksdb to grocksdb #236

Closed faddat closed 2 years ago

faddat commented 2 years ago

If these are unwanted changes, please let me know, and I'll make a PR that removes RocksDB

NB: tests are failing because the docker image is out of date, specifically this PR makes the dockerfile use rocks v7, but the one that is currently used to run tests is rocks v6

faddat commented 2 years ago

NB: This will continue to fail, as will tests in the cosmos-sdk, because our Dockerfile uses rocksdb v6.

Because of how CI is set up, this isn't avoidable, this PR would need to be merged.

codecov[bot] commented 2 years ago

Codecov Report

Merging #236 (49b89fd) into master (3b4b586) will not change coverage. The diff coverage is 92.30%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #236   +/-   ##
=======================================
  Coverage   68.54%   68.54%           
=======================================
  Files          27       27           
  Lines        2130     2130           
=======================================
  Hits         1460     1460           
  Misses        595      595           
  Partials       75       75
Impacted Files Coverage Δ
db.go 35.00% <ø> (ø)
rocksdb.go 72.26% <90.00%> (ø)
rocksdb_batch.go 84.31% <100.00%> (ø)
rocksdb_iterator.go 93.02% <100.00%> (ø)
Impacted Files Coverage Δ
db.go 35.00% <ø> (ø)
rocksdb.go 72.26% <90.00%> (ø)
rocksdb_batch.go 84.31% <100.00%> (ø)
rocksdb_iterator.go 93.02% <100.00%> (ø)
github-actions[bot] commented 2 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.