tendermint / tm-db

Common database interface for various database backends for Tendermint Core and Cosmos SDK
Apache License 2.0
89 stars 136 forks source link

rocksdb: pedantic error checks that could just be direct returns #263

Closed odeke-em closed 2 years ago

odeke-em commented 2 years ago

If we examine the code in RocksDB, we can see this pedantic pattern that could instead be a direct return image

faddat commented 2 years ago

but the key thing is that we don't use rocksdb v7

odeke-em commented 2 years ago

Thanks @faddat for the reply and for fixing this issue. Ahah nice that you noticed it was an iPad