tendermint / tm-db

Common database interface for various database backends for Tendermint Core and Cosmos SDK
Apache License 2.0
89 stars 136 forks source link

fix cleveldb Stats() #273

Closed luohaha closed 2 years ago

luohaha commented 2 years ago

Remove unmatch property keys and add useful property key. https://github.com/google/leveldb/blob/main/db/db_impl.cc#L1387

faddat commented 2 years ago

Ahhhhh got it. Does this fix the issue I mentioned in #275 ?

Thank you

luohaha commented 2 years ago

Ahhhhh got it. Does this fix the issue I mentioned in #275 ?

Thank you

It doesn't fix your issue. The change I make is just for fixing stats() in cleveldb.

faddat commented 2 years ago

oh, I wonder (lots) what's going on there!

Thanks for the patch

This repo isn't getting a ton of action really-- tell me sir, are you using cleveldb?

In our omnibus update branch, I removed cleveldb, but could re-include it if you'd like.

faddat commented 2 years ago

Fixed it. It was the certificates, I think they'd expired.

luohaha commented 2 years ago

Yeah, I am using cleveldb, and when I want to print some internal statistics in cleveldb, it can't work.

tac0turtle commented 2 years ago

seems tests area failing, @luohaha could take a look?

faddat commented 2 years ago

Tests are failing because #280 is not merged into this branch. In my branches, test pass, only because I merged it in.

eg: master is broken.

codecov[bot] commented 2 years ago

Codecov Report

Merging #273 (08dedb0) into master (fce26e6) will decrease coverage by 0.06%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
- Coverage   68.03%   67.97%   -0.07%     
==========================================
  Files          27       27              
  Lines        2093     2089       -4     
==========================================
- Hits         1424     1420       -4     
  Misses        594      594              
  Partials       75       75              
Impacted Files Coverage Δ
cleveldb.go 70.07% <100.00%> (-0.92%) :arrow_down:
Impacted Files Coverage Δ
cleveldb.go 70.07% <100.00%> (-0.92%) :arrow_down:
luohaha commented 2 years ago

Tests are failing because #280 is not merged into this branch. In my branches, test pass, only because I merged it in.

eg: master is broken.

Thanks, I misunderstand what you say before.