search

tendermint / tm-db

Common database interface for various database backends for Tendermint Core and Cosmos SDK
Apache License 2.0
89 stars 136 forks source link

remove badgerdb and boltdb #276

Closed faddat closed 2 years ago

faddat commented 2 years ago

This PR attempts to lower the matienance scope of the tm-db repository by removing databases with no known users.

Further, badgerdb has now entered the status of abandonware and is no longer actively maintained.

tac0turtle commented 2 years ago

I love the reduction. Could you add a changelog entry?

I guess the issue here is if someone is using it they will need to resync the db. Maybe we mark them as deprecated and put a EOL date a few months into the future?

faddat commented 2 years ago

I actually don't think it is needed (the EOL) because they could always bump the version downwards, and maybe more importantly, I don't know of any successful deployments of badger or bolt.

None of the changes here break the api, so the bumping down technique should work quite fine

tac0turtle commented 2 years ago

@mvdan I believe you added badger, do you use it?

mvdan commented 2 years ago

Not anymore for new projects; it's been semi-abandoned for some time and it's hard to run smoothly at scale. I've rediscovered sqlite in the meantime :)

faddat commented 2 years ago

Hi @mvdan -- just wanted to say thanks for gofumpt!

I'm a daily user :)