search

tendermint / tm-db

Common database interface for various database backends for Tendermint Core and Cosmos SDK
Apache License 2.0
89 stars 136 forks source link

Grocksdb and docker #278

Closed faddat closed 2 years ago

faddat commented 2 years ago

This PR introduces grocksdb and a docker container that has rocksdb v7.x in it

codecov[bot] commented 2 years ago

Codecov Report

Merging #278 (62b1275) into master (b599fa5) will not change coverage. The diff coverage is 92.30%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #278   +/-   ##
=======================================
  Coverage   68.30%   68.30%           
=======================================
  Files          27       27           
  Lines        2073     2073           
=======================================
  Hits         1416     1416           
  Misses        586      586           
  Partials       71       71
Impacted Files Coverage Δ
db.go 35.00% <ø> (ø)
rocksdb.go 78.51% <90.00%> (ø)
rocksdb_batch.go 84.31% <100.00%> (ø)
rocksdb_iterator.go 92.94% <100.00%> (ø)
Impacted Files Coverage Δ
db.go 35.00% <ø> (ø)
rocksdb.go 78.51% <90.00%> (ø)
rocksdb_batch.go 84.31% <100.00%> (ø)
rocksdb_iterator.go 92.94% <100.00%> (ø)
faddat commented 2 years ago

You're right it definitely needs docs.

This upgrades gorocksdb to grocksdb, meaning that we need to use as container that has rocks 7.x in it. So at the same time, I changed both the dev container and the version of rocks.