search

tendermint / tm-db

Common database interface for various database backends for Tendermint Core and Cosmos SDK
Apache License 2.0
89 stars 136 forks source link

Goleveldb settings from omnibus #288

Closed faddat closed 2 years ago

faddat commented 2 years ago

These are the goleveldb settings from the omnibus update branch.

They improve performance, but not nearly as much as pebble.

codecov[bot] commented 2 years ago

Codecov Report

Merging #288 (f3bdee1) into master (b599fa5) will increase coverage by 0.34%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
+ Coverage   68.30%   68.65%   +0.34%     
==========================================
  Files          27       27              
  Lines        2073     2096      +23     
==========================================
+ Hits         1416     1439      +23     
  Misses        586      586              
  Partials       71       71
Impacted Files Coverage Δ
goleveldb.go 65.13% <100.00%> (+6.21%) :arrow_up:
Impacted Files Coverage Δ
goleveldb.go 65.13% <100.00%> (+6.21%) :arrow_up:
tac0turtle commented 2 years ago

lets spin up a node with this and compare.

tac0turtle commented 2 years ago

can you touch on why these are changed?