fix: long overdue refactor

[faddat]

This is prepared for pebble support in Celestia without breaking changes

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 73.70130% with 81 lines in your changes are missing coverage. Please review.

Project coverage is 74.94%. Comparing base (774cdfe) to head (fc0fbd3).

Additional details and impacted files

[](https://app.codecov.io/gh/tendermint/tm-db/pull/359?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint) ```diff @@ Coverage Diff @@ ## master #359 +/- ## ========================================== + Coverage 68.30% 74.94% +6.63% ========================================== Files 27 13 -14 Lines 2073 930 -1143 ========================================== - Hits 1416 697 -719 + Misses 586 190 -396 + Partials 71 43 -28 ``` | [Files](https://app.codecov.io/gh/tendermint/tm-db/pull/359?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint) | Coverage Δ | | |---|---|---| | [goleveldb\_batch.go](https://app.codecov.io/gh/tendermint/tm-db/pull/359?src=pr&el=tree&filepath=goleveldb_batch.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-Z29sZXZlbGRiX2JhdGNoLmdv) | `94.44% <ø> (+1.11%)` | :arrow_up: | | [prefixdb.go](https://app.codecov.io/gh/tendermint/tm-db/pull/359?src=pr&el=tree&filepath=prefixdb.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-cHJlZml4ZGIuZ28=) | `71.30% <100.00%> (+7.74%)` | :arrow_up: | | [prefixdb\_iterator.go](https://app.codecov.io/gh/tendermint/tm-db/pull/359?src=pr&el=tree&filepath=prefixdb_iterator.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-cHJlZml4ZGJfaXRlcmF0b3IuZ28=) | `81.25% <100.00%> (+0.23%)` | :arrow_up: | | [test\_helpers.go](https://app.codecov.io/gh/tendermint/tm-db/pull/359?src=pr&el=tree&filepath=test_helpers.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-dGVzdF9oZWxwZXJzLmdv) | `100.00% <100.00%> (ø)` | | | [util.go](https://app.codecov.io/gh/tendermint/tm-db/pull/359?src=pr&el=tree&filepath=util.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-dXRpbC5nbw==) | `40.00% <100.00%> (+3.33%)` | :arrow_up: | | [db.go](https://app.codecov.io/gh/tendermint/tm-db/pull/359?src=pr&el=tree&filepath=db.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-ZGIuZ28=) | `41.17% <50.00%> (+6.17%)` | :arrow_up: | | [goleveldb.go](https://app.codecov.io/gh/tendermint/tm-db/pull/359?src=pr&el=tree&filepath=goleveldb.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-Z29sZXZlbGRiLmdv) | `65.51% <84.21%> (+6.60%)` | :arrow_up: | | [memdb\_iterator.go](https://app.codecov.io/gh/tendermint/tm-db/pull/359?src=pr&el=tree&filepath=memdb_iterator.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-bWVtZGJfaXRlcmF0b3IuZ28=) | `91.46% <50.00%> (-1.95%)` | :arrow_down: | | [memdb.go](https://app.codecov.io/gh/tendermint/tm-db/pull/359?src=pr&el=tree&filepath=memdb.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-bWVtZGIuZ28=) | `70.65% <71.42%> (+0.38%)` | :arrow_up: | | [pebble.go](https://app.codecov.io/gh/tendermint/tm-db/pull/359?src=pr&el=tree&filepath=pebble.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-cGViYmxlLmdv) | `70.71% <70.71%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/tendermint/tm-db/pull/359/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint) | [Files](https://app.codecov.io/gh/tendermint/tm-db/pull/359?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint) | Coverage Δ | | |---|---|---| | [goleveldb\_batch.go](https://app.codecov.io/gh/tendermint/tm-db/pull/359?src=pr&el=tree&filepath=goleveldb_batch.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-Z29sZXZlbGRiX2JhdGNoLmdv) | `94.44% <ø> (+1.11%)` | :arrow_up: | | [prefixdb.go](https://app.codecov.io/gh/tendermint/tm-db/pull/359?src=pr&el=tree&filepath=prefixdb.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-cHJlZml4ZGIuZ28=) | `71.30% <100.00%> (+7.74%)` | :arrow_up: | | [prefixdb\_iterator.go](https://app.codecov.io/gh/tendermint/tm-db/pull/359?src=pr&el=tree&filepath=prefixdb_iterator.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-cHJlZml4ZGJfaXRlcmF0b3IuZ28=) | `81.25% <100.00%> (+0.23%)` | :arrow_up: | | [test\_helpers.go](https://app.codecov.io/gh/tendermint/tm-db/pull/359?src=pr&el=tree&filepath=test_helpers.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-dGVzdF9oZWxwZXJzLmdv) | `100.00% <100.00%> (ø)` | | | [util.go](https://app.codecov.io/gh/tendermint/tm-db/pull/359?src=pr&el=tree&filepath=util.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-dXRpbC5nbw==) | `40.00% <100.00%> (+3.33%)` | :arrow_up: | | [db.go](https://app.codecov.io/gh/tendermint/tm-db/pull/359?src=pr&el=tree&filepath=db.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-ZGIuZ28=) | `41.17% <50.00%> (+6.17%)` | :arrow_up: | | [goleveldb.go](https://app.codecov.io/gh/tendermint/tm-db/pull/359?src=pr&el=tree&filepath=goleveldb.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-Z29sZXZlbGRiLmdv) | `65.51% <84.21%> (+6.60%)` | :arrow_up: | | [memdb\_iterator.go](https://app.codecov.io/gh/tendermint/tm-db/pull/359?src=pr&el=tree&filepath=memdb_iterator.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-bWVtZGJfaXRlcmF0b3IuZ28=) | `91.46% <50.00%> (-1.95%)` | :arrow_down: | | [memdb.go](https://app.codecov.io/gh/tendermint/tm-db/pull/359?src=pr&el=tree&filepath=memdb.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-bWVtZGIuZ28=) | `70.65% <71.42%> (+0.38%)` | :arrow_up: | | [pebble.go](https://app.codecov.io/gh/tendermint/tm-db/pull/359?src=pr&el=tree&filepath=pebble.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint#diff-cGViYmxlLmdv) | `70.71% <70.71%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/tendermint/tm-db/pull/359/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tendermint)

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.