put_auth_key missing delegated_capabilities

tendermint / yubihsm-rs

Pure Rust client for YubiHSM2 devices

https://docs.rs/yubihsm/

70 stars 10 forks source link

put_auth_key missing delegated_capabilities #68

Closed archaelus closed 6 years ago

archaelus commented 6 years ago

The put auth key function @ put_auth_key.rs:23 is missing a delegated capabilities parameter, which is specified in https://developers.yubico.com/YubiHSM2/Commands/Put_Authkey.html as 8 bytes before the key material.

I think this needs to be changed to something along the lines of put_wrap_key.

tarcieri commented 6 years ago

I so happen to be in the process of rewriting much of the auth key code right now in a local branch I haven't published yet, but I noticed this as well while writing an integration test for put_auth_key and have already fixed it. I'll push up my branch as a PR shortly (i.e. later today).

archaelus commented 6 years ago

:+1:

tarcieri commented 6 years ago

Fixed in 313b46e