search

tenders-exposed / elvis-ember

**el.vis** - a tool for visualising public (EU) tenders big data
https://talk.tenders.exposed
GNU Affero General Public License v3.0
8 stars 2 forks source link

flags in tender details are wrong #469

Closed zufanka closed 4 years ago

zufanka commented 5 years ago

If I select multiple countries on the query builder, all of them appear in the country from which the tender comes. This is not accurate. It should take the value out of _tendercountry in the API

image

UPDATE We don't have a tender details anymore, but it's an issue in the government details page too image

zufanka commented 5 years ago

@nightsh @georgiana-b what is the status of this??

zufanka commented 4 years ago

@nightsh @ca1yps0 fix pls?

georgiana-b commented 4 years ago

Sorry guys, you shouldn't be digging for the country all the way into the bidder/buyer objects.

I'm going to add a new country attribute to nodes and countries to clusters where I will send the country of the original bidder or bidders in the case of a cluster.

georgiana-b commented 4 years ago

Opened https://github.com/georgiana-b/defense-elvis-backend/issues/14 about it. I'll keep you posted

georgiana-b commented 4 years ago

This issue has been fixed in https://github.com/georgiana-b/defense-elvis-backend/issues/14.

You will now find a new attribute countries in node details and cluster details that is an array of country codes of the bidder/buyer in question.

image

❗ In the case of manual data, this array will always be empty because we don't know the actors address so make sure you also cover that case.