Network creation query without CPVs results in a network without edges and nodes

tenders-exposed / elvis-ember

**el.vis** - a tool for visualising public (EU) tenders big data

https://talk.tenders.exposed

GNU Affero General Public License v3.0

8 stars 2 forks source link

Network creation query without CPVs results in a network without edges and nodes #517

Open nightsh opened 4 years ago

nightsh commented 4 years ago

Example network: https://defense.tenders.exposed/network/395ec875-ec97-41f3-afe2-083d5dccb1c9

Steps to reproduce:

go to query builder
select at least a country
select no actor
select no CPV, click on the "proceed anyway" warning
at the final step, submit the request
loading carousel appears, but the nework that comes back from the backend is invalid, hence nothing is rendered

georgiana-b commented 4 years ago

Hey @nightsh! Thanks for pointing out.

This is not a bug in Elvis actually. The original data just happens to lack the name of the bidders sometimes. https://drive.google.com/file/d/1TNYwKIbPUwHowEwv_DFOVXfCiRnOmC_C/view?usp=sharing

It's one of those cases where it would really help to see the network query 😄Then it would become pretty clear that it has anything to do with the CPVs at all. This is how the network query looks in the db. It's perfectly fine but you're getting those nameless bidders because you chose Greece.

@zufanka We actually talked about this in https://github.com/tenders-exposed/elvis-ember/issues/428. The idea was to show the nameless bidders/buyers as grey nodes. I see that the issue was closed a few days ago. Does that mean we're dropping that idea?

zufanka commented 4 years ago

That issue was about them not appearing at all. The issue was closed because they now do appear as a node with no name.

georgiana-b commented 4 years ago

How do they appear though?

georgiana-b commented 4 years ago

I don't understand how we decided to display the tenders who are missing the bidders

zufanka commented 4 years ago

I am confused: #428 was about "bidders missing a name", not tenders that are missing bidders?

georgiana-b commented 4 years ago

I am confused: #428 was about "bidders missing a name", not tenders that are missing bidders?

@zufanka This are the same thing in the data: a tender record with an empty cell in the bidder name. Of course there must've been a bidder if the tender was awarded but we don't know it.

I suggest we close this issue in favour of https://github.com/tenders-exposed/elvis-ember/issues/524

zufanka commented 4 years ago

@georgiana-b I think this something else. If you create a network but select no CPV codes at all, it does not select all CPV codes, instead it selects nothing at all. See https://defense.tenders.exposed/network/d0649fbb-f298-4d26-83ac-5abc592a6978/ for example