tendrilinc / marathon-autoscaler

A simple autoscaler for Marathon applications
https://hub.docker.com/r/tendril/marathon-autoscaler/
Apache License 2.0
41 stars 16 forks source link

Unnecessary datadog errors #38

Open mentalblock opened 7 years ago

mentalblock commented 7 years ago

When a mesos agent cannot be queried, the datadog methods do not have all data necessary to make a valid calls in the function send_datadog_metrics. This is just a minor issue, as it can just be misleading in what the actual issue is.

Perhaps this can be fixed by checking the data before trying to build the metric data structure?

2017-08-03 14:50:29,183 | ERROR | "'points' parameter is required" (send_datadog_metrics:81) 2017-08-03 14:50:26,180 | ERROR | HTTPConnectionPool(host='10.91.24.4', port=5051): Max retries exceeded with url: /monitor/statistics (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x7f9b5b1ad690>: Failed to establish a new connection: [Errno 111] Connection refused',)) (_do_request:69)