search

tenex / rails-assets

The solution to assets management in Rails
https://rails-assets.org
MIT License
1.63k stars 69 forks source link

Too many slicks #399

Closed dsandstrom closed 7 years ago

dsandstrom commented 7 years ago

There are at least three somewhat identical gems that pull in https://github.com/kenwheeler/slick. Moreover, one is broken.

Broken: https://rails-assets.org/#/components/slick.js When you specify slick.js in your javascript assets file, it pulls in a css file. I assume because the css is erroneously named slick.js.css.

Seems to be working: https://rails-assets.org/#/components/slick-carousel Although, slick-carousel needs to be required after jquery unlike the instructions demonstrate.

Untested: https://rails-assets.org/#/components/kenwheeler--slick Looks identical to the others.

dsandstrom commented 7 years ago

I was able to get the js file to work for slick.js by using require slick.js.js, but not sure how to require the css file. I tried slick.js, slick.js.css, slick.js.scss, and slick. Going to stick with slick-carousel package.

hut8 commented 7 years ago

Is this the same as https://github.com/tenex/rails-assets/issues/361 ?

dsandstrom commented 7 years ago

It's similar, but there seems to be a problem with duplicate gems. That issue may explain how to get slick.js working, but it doesn't seem worth the effort when we have 2 others to pick from.

hut8 commented 7 years ago

When you say it's similar, how is it different?

Also, we're pulling bower information directly from the bower registry. So (unless you find differently), those are probably all listed in Bower as separate packages. That would be an issue to take up with the maintainer(s) of Bower, since it's risky for us to selectively determine which is the "best" bower package that references the same repo. Does that make sense?

dsandstrom commented 7 years ago

Sorry, didn't realize that the problem resides with bower. I'll close this.