search

tenex / rails-assets

The solution to assets management in Rails
https://rails-assets.org
MIT License
1.63k stars 69 forks source link

popper.js does not have dist/ #409

Closed glebm closed 7 years ago

glebm commented 7 years ago

For some reason, the rails-assets-popper.js https://github.com/FezVrasta/popper.js, does not have the dist/ directory.

It is a dependency of the current Bootstrap 4 master, so it'd be nice if it worked.

hut8 commented 7 years ago

Looking now.

hut8 commented 7 years ago

Looks like popper.js doesn't really support bower:

It seems like the maintainer of that project isn't really interested in supporting bower, which is his choice, but unfortunately since there is no bower metadata in the project's repository, there's nothing we can do here.

glebm commented 7 years ago

Thank you! Do you know if there is a bundler-to-yarn/npm proxy?

hut8 commented 7 years ago

I'm afraid not. However, you can use these natively with Rails 5.1:

http://weblog.rubyonrails.org/2017/4/27/Rails-5-1-final/

glebm commented 7 years ago

Well I'm packaging Bootstrap 4 for Sprockets so I need a gem. I've solved the problem by packaging popper.js as a rubygem: https://github.com/glebm/popper_js-rubygem

joshjordan commented 7 years ago

We really would like to implement bundler-to-yarn/npm, as you say, in Rails Assets. PRs welcome. Poke me if this is something you (or anyone else!) would like to work on.

klihelp commented 7 years ago

Need list, es5?

joshjordan commented 7 years ago

Can you elaborate?

FezVrasta commented 7 years ago

How could a bower metadata file help you? I'm not against Bower per se, I'm against the idea to put compiled code in the repository.

If the idea is to simply add a bower.json file I'm okay with it.

hut8 commented 7 years ago

Unfortunately it's really an issue of putting compiled code in the repository. I understand why you're against it, but rails-assets.org can't work without it since Bower's file format doesn't give any hints as to how to build the code in the first place 😄

FezVrasta commented 7 years ago

¯\_(ツ)_/¯

joshjordan commented 7 years ago

@glebm your best bet is probably to fork it, compile it, commit it, and point Rails Assets at your fork.

FezVrasta commented 7 years ago

I'm open to PRs to introduce some kind of automatic magic that pushes the compiled stuff in a different branch on each release. Always if Bower allows to define a branch different from master...