Add Snap support - Githubissues

tengattack / certbot-dns-dnspod

A certbot dns plugin to obtain certificates using dnspod.

Other

68 stars 18 forks source link

Add Snap support #11

Closed EricZhang456 closed 2 years ago

EricZhang456 commented 2 years ago

I already have a Snap live at https://snapcraft.io/certbot-dns-dnspod

tengattack commented 2 years ago

Thank you

EricZhang456 commented 2 years ago

btw check the comment in snap/snapcraft.yaml

tengattack commented 2 years ago

btw check the comment in snap/snapcraft.yaml

@EricZhang456 ：)

https://github.com/tengattack/certbot-dns-dnspod/commit/e94bc6ffaae635166a4bae6ef53ce6274f9ae40b

tengattack commented 2 years ago

BTW, did you build Snap package in Docker or Local Machine? I want to configure a GitHub pipeline to do it automatically after publishing a version.

EricZhang456 commented 2 years ago

BTW, did you build Snap package in Docker or Local Machine? I want to configure a GitHub pipeline to do it automatically after publishing a version.

Local. Also check your inbox (tengattack@foxmail.com), I have sent an invitation for Snap package collaboration

EricZhang456 commented 2 years ago

GitHub Pipeline is not necessary anymore. The Snap Store has a new feature that allows building Snap package directly from the GitHub repo.

Side note here, my Snap currently requires manual review as I have a support website specified. It's a new feature in Snapcraft 5.0 and has not been added to the automatic review tool. More info here.

Thu 23 Dec. 2021

批准 by Maria Emilia Torino. “Manually approving since the support for links is not added yet to the automated review” — Maria Emilia Torino

tengattack commented 2 years ago

BTW, did you build Snap package in Docker or Local Machine? I want to configure a GitHub pipeline to do it automatically after publishing a version.

Local. Also check your inbox (tengattack@foxmail.com), I have sent an invitation for Snap package collaboration

Could you send the invitation to my gmail (tengattack@gmail.com)? I already have the account on Snap.

tengattack commented 2 years ago

GitHub Pipeline is not necessary anymore. The Snap Store has a new feature that allows building Snap package directly from the GitHub repo.

Side note here, my Snap currently requires manual review as I have a support website specified. It's a new feature in Snapcraft 5.0 and has not been added to the automatic review tool. More info here.

Thu 23 Dec. 2021 批准 by Maria Emilia Torino. “Manually approving since the support for links is not added yet to the automated review” — Maria Emilia Torino

Thank you, I will try it later

EricZhang456 commented 2 years ago

BTW, did you build Snap package in Docker or Local Machine? I want to configure a GitHub pipeline to do it automatically after publishing a version.

Local. Also check your inbox (tengattack@foxmail.com), I have sent an invitation for Snap package collaboration

Could you send the invitation to my gmail (tengattack@gmail.com)? I already have the account on Snap.

Sure